Skip to content

Handle malformed fragment decoding as a parse error#171

Merged
mcollina merged 1 commit intomainfrom
fix/malformed-fragment-decoding
May 5, 2026
Merged

Handle malformed fragment decoding as a parse error#171
mcollina merged 1 commit intomainfrom
fix/malformed-fragment-decoding

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented May 4, 2026

Summary

  • handle malformed fragment decoding as a parse error instead of throwing
  • preserve the original fragment value when decoding fails
  • add regression coverage for parse(), resolve(), and equal()

Testing

  • npm test

@mcollina mcollina requested review from climba03003 and gurgunday May 4, 2026 08:20
gurgunday
gurgunday approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, totally missed this

lgtm

@mcollina mcollina merged commit a95158a into main May 5, 2026
64 of 65 checks passed
@mcollina mcollina deleted the fix/malformed-fragment-decoding branch May 5, 2026 08:26
@rtibblesbot rtibblesbot mentioned this pull request May 8, 2026
Merged
@lifeomic-review-bot lifeomic-review-bot Bot mentioned this pull request May 8, 2026
Open
@claude claude Bot mentioned this pull request May 9, 2026
Merged
@github-actions github-actions Bot mentioned this pull request May 9, 2026
Open
mergify Bot added a commit to ArcadeData/arcadedb that referenced this pull request May 9, 2026
@mergify
chore(deps-dev): bump fast-uri from 3.1.0 to 3.1.2 in /studio [skip ci]
9a61991 
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2.
Release notes

*Sourced from [fast-uri's releases](https://github.com/fastify/fast-uri/releases).*

> v3.1.2
> ------
>
> ⚠️ Security Release
> -------------------
>
> * Fix for <GHSA-v39h-62p7-jpjc>
>
> What's Changed
> --------------
>
> * Handle malformed fragment decoding as a parse error by [`@​mcollina`](https://github.com/mcollina) in [fastify/fast-uri#171](https://redirect.github.com/fastify/fast-uri/pull/171)
>
> **Full Changelog**: <fastify/fast-uri@v3.1.1...v3.1.2>
>
> v3.1.1
> ------
>
> ⚠️ Security Release
> -------------------
>
> * Fix for <GHSA-q3j6-qgpj-74h6>
>
> What's Changed
> --------------
>
> * build(deps-dev): bump tsd from 0.32.0 to 0.33.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#148](https://redirect.github.com/fastify/fast-uri/pull/148)
> * build(deps): bump actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#149](https://redirect.github.com/fastify/fast-uri/pull/149)
> * chore(.npmrc): ignore scripts by [`@​Fdawgs`](https://github.com/Fdawgs) in [fastify/fast-uri#150](https://redirect.github.com/fastify/fast-uri/pull/150)
> * build(deps-dev): remove `@​fastify/pre-commit` by [`@​Fdawgs`](https://github.com/Fdawgs) in [fastify/fast-uri#151](https://redirect.github.com/fastify/fast-uri/pull/151)
> * build(deps): bump actions/setup-node from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#152](https://redirect.github.com/fastify/fast-uri/pull/152)
> * ci(ci): add concurrency config by [`@​Fdawgs`](https://github.com/Fdawgs) in [fastify/fast-uri#153](https://redirect.github.com/fastify/fast-uri/pull/153)
> * build(deps): bump actions/setup-node from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#154](https://redirect.github.com/fastify/fast-uri/pull/154)
> * build(deps): bump actions/checkout from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#156](https://redirect.github.com/fastify/fast-uri/pull/156)
> * chore(license): standardise license notice by [`@​Fdawgs`](https://github.com/Fdawgs) in [fastify/fast-uri#159](https://redirect.github.com/fastify/fast-uri/pull/159)
> * style: remove trailing whitespace by [`@​Fdawgs`](https://github.com/Fdawgs) in [fastify/fast-uri#161](https://redirect.github.com/fastify/fast-uri/pull/161)
> * ci: remove unused github files by [`@​Tony133`](https://github.com/Tony133) in [fastify/fast-uri#162](https://redirect.github.com/fastify/fast-uri/pull/162)
> * chore: update readme by [`@​Tony133`](https://github.com/Tony133) in [fastify/fast-uri#164](https://redirect.github.com/fastify/fast-uri/pull/164)
> * build(deps): bump fastify/workflows/.github/workflows/plugins-ci-package-manager.yml from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#165](https://redirect.github.com/fastify/fast-uri/pull/165)
> * build(deps): bump fastify/workflows/.github/workflows/plugins-ci.yml from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#166](https://redirect.github.com/fastify/fast-uri/pull/166)
> * build(deps-dev): bump neostandard from 0.12.2 to 0.13.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [fastify/fast-uri#167](https://redirect.github.com/fastify/fast-uri/pull/167)
> * ci: add lock-threads workflow by [`@​Fdawgs`](https://github.com/Fdawgs) in [fastify/fast-uri#169](https://redirect.github.com/fastify/fast-uri/pull/169)
>
> New Contributors
> ----------------
>
> * [`@​Tony133`](https://github.com/Tony133) made their first contribution in [fastify/fast-uri#162](https://redirect.github.com/fastify/fast-uri/pull/162)
>
> **Full Changelog**: <fastify/fast-uri@v3.1.0...v3.1.1>


Commits

* [`919dd8e`](fastify/fast-uri@919dd8e) Bumped v3.1.2
* [`c65ba57`](fastify/fast-uri@c65ba57) fixup: linting
* [`6c86c17`](fastify/fast-uri@6c86c17) Merge commit from fork
* [`a95158a`](fastify/fast-uri@a95158a) Handle malformed fragment decoding without throwing ([#171](https://redirect.github.com/fastify/fast-uri/issues/171))
* [`cea547c`](fastify/fast-uri@cea547c) Bumped v3.1.1
* [`876ce79`](fastify/fast-uri@876ce79) Merge commit from fork
* [`dcdf690`](fastify/fast-uri@dcdf690) ci: add lock-threads workflow ([#169](https://redirect.github.com/fastify/fast-uri/issues/169))
* [`c860e65`](fastify/fast-uri@c860e65) build(deps-dev): bump neostandard from 0.12.2 to 0.13.0 ([#167](https://redirect.github.com/fastify/fast-uri/issues/167))
* [`9b4c6dc`](fastify/fast-uri@9b4c6dc) build(deps): bump fastify/workflows/.github/workflows/plugins-ci.yml ([#166](https://redirect.github.com/fastify/fast-uri/issues/166))
* [`85d09a9`](fastify/fast-uri@85d09a9) build(deps): bump fastify/workflows/.github/workflows/plugins-ci-package-mana...
* Additional commits viewable in [compare view](fastify/fast-uri@v3.1.0...v3.1.2)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=fast-uri&package-manager=npm\_and\_yarn&previous-version=3.1.0&new-version=3.1.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/ArcadeData/arcadedb/network/alerts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gurgunday gurgunday gurgunday approved these changes

@climba03003 climba03003 Awaiting requested review from climba03003

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcollina @gurgunday