Skip to content

Add View to layer name map for pytorch parser #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

JanFSchulte
Copy link
Contributor

@JanFSchulte JanFSchulte commented Jul 19, 2024

Add a mapping of 'view' -> "View" to the pytorch converter to allow this type of operation to be parsed correctly. Fixes #1038

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)

Tests

Verified that it fixes the crash reported in #1038

Test Configuration:

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@JanFSchulte JanFSchulte added bug please test Trigger testing by creating local PR branch labels Jul 19, 2024
@vloncar
Copy link
Contributor

vloncar commented Jul 19, 2024

Can we add a test? Basically a simpler version of what was done in the bug report

@JanFSchulte
Copy link
Contributor Author

Yep, working on it.

@JanFSchulte JanFSchulte added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Jul 19, 2024
@vloncar vloncar added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Jul 22, 2024
@JanFSchulte
Copy link
Contributor Author

Should we add Vitis also for the other tests in this file while we're at it?

@vloncar
Copy link
Contributor

vloncar commented Jul 22, 2024

Ah, I didn't notice we don't do Vitis in these tests. I guess we can add it now, but maybe as a separate PR.

@JanFSchulte
Copy link
Contributor Author

Not quite sure anymore why I didn't include it in the first place. I can prepare a separate PR to add it everywhere.

@vloncar vloncar merged commit 7982c87 into fastmachinelearning:main Jul 22, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torch "View"
2 participants