Revert accum_t precision set to layer input type #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reverted the change to hls_layers.py introduced by this commit.
The comment says "We set 'accum' precision to match input tensor's precision if 'accum' was not explicitly set", but it actually checks whether the data type is the same as the default type. So when I explicitly set
'ap_fixed<16,6>'in the config, if the model default is also'ap_fixed<16,6>'then this code actually overrides that to change the accumulator type to the same as the layer input type regardless. In essence, it's not possible to explicitly set the accumulator data type now.@maksgraczyk has implemented the automatic setting of accumulator type in PR #321 which can set the type to something better than the default precision in cases where that's appropriate.