-
Notifications
You must be signed in to change notification settings - Fork 462
Transpose2d, Concatenate2d, and up to 3 Clones for io_stream #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6d24f0
to
b0e55c3
Compare
Thanks for this, looks nice! To be clear, for the review, only the increase from 1 to 100 test examples is a requested change, the other items are for discussion. I tested with the 100 examples and it still works fine. I ran cosim as well since the io_stream version could have some dataflow behaviour: all good there too. Maybe something for the future: now we have layers to clone a stream 2 times and another to clone it 3 times. Can there be a |
@thesps I responded to your comments and added some follow-up questions. We should probably have a |
Added |
d1b8814
to
c4baaed
Compare
This PR has 3 independent, minor changes (I can split them into smaller PRs if needed):
io_stream
io_stream
These features are needed, for example in this interaction network model: https://gist.github.com/jmduarte/9ea95df65feac29f9663c47a439e2d7e