Use correct number of args for multiple outputs #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
|
This PR needs a unit test added before it can be merged to follow the contribution guidelines. |
This comment was marked as spam.
This comment was marked as spam.
jmduarte
force-pushed
the
predict-multiple-outputs
branch
from
e3fab15 to
1c302ad
Compare
jmduarte
changed the title
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
…ple-outputs Use correct number of args for multiple outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments set for
top_functionassumed there could be multiple inputs but only one output. If there were multiple outputs, theargtupledid not match the parameters in the generated HLS function, and caused a seg fault when callingpredict().