VivadoAccelerator backend updates #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small things:
VivadoAcceleratorBackend
writer flow. In master branch, the writer flow for that backend is justVivadoBackend
's writer flow relabelled, so the extra files forVivadoAcceleratorBackend
aren't written out.VivadoAcceleratorBackend.make_bitfile
method withbuild(bitfile=True)
. This is an API change to make that workflow more consistent with the usualbuild
API (rather than requiring one call tobuild
then one call tomake_bitfile
)package
method to make a .tar.gz archive with all the necesary files for hardware inference - otherwise the user needs to do some finding and renaming of files themselves