Skip to content

Add tracing support for the quartus backend #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2022
Merged

Add tracing support for the quartus backend #583

merged 5 commits into from
Jul 22, 2022

Conversation

jmitrevs
Copy link
Contributor

Description

Tracing was only partially supported in the Quartus backend. This adds the missing features to enable support in the currently supported io_parallel style. (This will need to be expanded when streaming is added.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)

Tests

test_trace.py is added in pytest: it is a simple copy of the test_dense with tracing enabled.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation -- not needed; should be identical as Vivado,
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.B# Description

@jmitrevs
Copy link
Contributor Author

I just made pr/583 locally with this pull request.

@jmitrevs jmitrevs mentioned this pull request Jul 6, 2022
Closed
9 tasks
@jmitrevs
Copy link
Contributor Author

I think this is fairly straightforward and uncontroversial--mostly a copy of the Vivado behavior, updated for ac_fixed. I would recommend reviewing it so we can merge it.

@vloncar vloncar requested a review from bo3z July 21, 2022 17:09
bo3z
bo3z requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, happy to merge after removing the double declaration inside nnet_helpers.h

@bo3z
Copy link
Contributor

bo3z commented Jul 22, 2022

All good, happy to merge.

@vloncar vloncar merged commit 19c541a into fastmachinelearning:main Jul 22, 2022
@jmitrevs jmitrevs deleted the quartus_trace branch July 22, 2022 14:39
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
@jmitrevs
Add tracing support for the quartus backend (fastmachinelearning#583)
40f15e6 
* partial first attempt to add tracing to quartus backend

* continue adding tracing for quartus

* Add trace pytest, fix bug uncovered in pytest

* add docstring

* remove redundant declaration, fix pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo3z bo3z bo3z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmitrevs @bo3z @vloncar