Skip to content

Fixes for GRU/LSTM in Vivado backend #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 15, 2022

Conversation

dsrankin
Copy link
Contributor

@dsrankin dsrankin commented Jul 13, 2022

Fixes for GRU/LSTM in Vivado backend

This PR fixes issues noted in #594 with the GRU/LSTM in the Vivado backend.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Tested using the configuration in the above issue and confirmed to fix issues.

@bo3z

Copy link
Contributor

@vloncar vloncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor cleanup should be done.

@vloncar vloncar merged commit 23770ca into main Jul 15, 2022
@jmduarte jmduarte deleted the pr/576-rnn-compilation-and-bias-issues branch November 2, 2022 02:37
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
…r/576-rnn-compilation-and-bias-issues

Fixes for GRU/LSTM in Vivado backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants