Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the old
io_serial
from the HLS templates.Why now? Well, I would like Vitis and Vivado implementations to be as similar as possible (ideally identical) and Vitis changed how
PIPELINE
pragma can be applied. So constructs likeare not allowed anymore, and the function doesn't get pipelined. Since we use this trick to switch between
io_parallel
andio_serial
, removingio_serial
will also get rid of the requirement for checking theio_type
. This allows the array-based implementations to be identical in Vitis and Vivado (at least it appears so, still need more tests).Type of change
Tests
No tests, we remove traces of non-functional code.