Skip to content

Remove io_serial #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Jul 17, 2022

Description

Remove the old io_serial from the HLS templates.

Why now? Well, I would like Vitis and Vivado implementations to be as similar as possible (ideally identical) and Vitis changed how PIPELINE pragma can be applied. So constructs like

if (CONFIG_T::io_type == io_parallel){
    #pragma HLS PIPELINE
}

are not allowed anymore, and the function doesn't get pipelined. Since we use this trick to switch between io_parallel and io_serial, removing io_serial will also get rid of the requirement for checking the io_type. This allows the array-based implementations to be identical in Vitis and Vivado (at least it appears so, still need more tests).

Type of change

  • Other (Specify) - Cleanup

Tests

No tests, we remove traces of non-functional code.

@thesps thesps merged commit f2f9593 into fastmachinelearning:main Jul 18, 2022
@vloncar vloncar mentioned this pull request Jul 18, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants