Fix keras model loading issue with loading model with KerasH5 #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably due to changes in the h5py. What version are you using? |
|
Currently 3.7.0. |
vloncar
requested changes
Oct 17, 2022
hls4ml/converters/keras_to_hls.py
Outdated
| @@ -232,7 +232,10 @@ def keras_to_hls(config): | |||
| if model_arch is None: | |||
| raise ValueError('No model found in config file.') | |||
| else: | |||
| model_arch = json.loads(model_arch.decode('utf-8')) | |||
| # model_arch should be a string by default. Keeping this if just for compatibility. | |||
There was a problem hiding this comment.
I tested this, and it seems to be an issue dating back to h5py version 3.0.0. Can you update this comment to include that? It will be easier in the future when we decide to clean up the codebase
There was a problem hiding this comment.
Thanks for tasting this out. I have updated the comment here.
calad0i
added a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
…chinelearning#664) * Fix keras model loading issue with loading model with KerasH5 * Add unit test for KerasH5 loader * comment on h5py version causing KerasH5 loading issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A# Description
In the current version of hls4ml, if one use the key "KerasH5" and not supplying the json model file to load the Keras model, the framework will try to decode the string in h5.attrs[ ] in utf-8 and fails. This PR patchs this issue by doing a type check first.
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Unit test added for KerasH5 loader at
test/pytest/test_keras_h5_loader.pyCreate any keras model, save it to .h5 and use only the
KerasH5without providing the in the config dictionary (or command line interface) to load it model json -> crashChecklist