Skip to content

Delete example-prjs directory #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Delete example-prjs directory #682

merged 1 commit into from
Nov 17, 2022

Conversation

jmduarte
Copy link
Member

Delete example-prjs directory as I don't believe we use it for anything.

Type of change

  • Other (Specify): cleanup

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

@jmduarte jmduarte force-pushed the delete-example-prjs branch from db171d4 to 8c44052 Compare November 17, 2022 04:21
@vloncar
Copy link
Contributor

vloncar commented Nov 17, 2022

YES! This has remained in the codebase for no useful reason and should be deleted. I do think that we should have examples, perhaps something that goes beyond the tutorial (like custom models with extension API, examples of tweaks etc)

@vloncar vloncar merged commit 57585cb into main Nov 17, 2022
@vloncar vloncar deleted the delete-example-prjs branch November 17, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants