Fix inplace variables #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmduarte
added
please test
7 tasks
jmitrevs
added
please test
vloncar
reviewed
Mar 8, 2023
vloncar
approved these changes
Mar 30, 2023
vloncar
added
please test
JanFSchulte
pushed a commit
to JanFSchulte/hls4ml
that referenced
this pull request
May 23, 2023
* extract inplace variables from qonnx branch * fix up reshape batch dimension handling * add repack stream for quartus * fix typo in HLS pragma * pre-commint cleanup, and add missing check for pragma not None * Minor cosmetic fixes --------- Co-authored-by: Vladimir Loncar <[email protected]>
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
* extract inplace variables from qonnx branch * fix up reshape batch dimension handling * add repack stream for quartus * fix typo in HLS pragma * pre-commint cleanup, and add missing check for pragma not None * Minor cosmetic fixes --------- Co-authored-by: Vladimir Loncar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inplace variables are broken in the main branch because they are fixed too early. Subsequent optimizations can make this connection no longer valid. Issue #707 (and the attempted fix in #708) is an example of this issue. This was largely developed in the
ingest-qonnx-masterbranch, but is extracted here, and an omission related to stream repacking for quartus was discovered and fixed.Type of change
Bug fix
Tests
The pytest,
test_reshape.py, is the main test, thoughtest_cnn_mnist.pyis also pertinent. The new reshape functionality for Intel needs testing, though. There is also the question of whether flatten can always be removed for io_stream. This should be checked further, and if exceptions are found, we may need to change when we run the optimizers.Checklist
pre-commiton the files I edited or added.