Skip to content

Fix precommits #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 3, 2023
Merged

Fix precommits #741

merged 30 commits into from
Apr 3, 2023

Conversation

jmitrevs
Copy link
Contributor

Description

Run the pre-commit hooks globally before the 0.7 release

Type of change

  • Other (Specify)

Tests

Standard tests should catch if this adds an error.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.

@jmitrevs jmitrevs added this to the v0.7.0 milestone Mar 31, 2023
@jmitrevs jmitrevs requested review from jmduarte and vloncar March 31, 2023 23:35
@jmitrevs
Copy link
Contributor Author

There is a circular import (I think) in pytests. Will try to fix.

Copy link
Member

@jmduarte jmduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vloncar vloncar added the please test Trigger testing by creating local PR branch label Apr 2, 2023
@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Apr 3, 2023
@jmduarte jmduarte merged commit 13148eb into main Apr 3, 2023
@jmduarte jmduarte deleted the fix_precommits branch April 3, 2023 18:56
JanFSchulte pushed a commit to JanFSchulte/hls4ml that referenced this pull request May 23, 2023
* Cleanup Vivado .h files

* Cleanup Quartus .h files

* pre-commit for pytests

* precommit to hls4ml script

* Cleanup Vitis .h files

* precommit for other tests

* pycommit for pyproject.toml

* pre-commits for writer

* pre-commits for utils

* pre-commits for templates

* fix scrits, quartus_report

* pre-commit for model

* pre-commit for converters

* pre-commit for backens

* pre-commit for __init__.py

* pre-commit for contrib

* precommit for global files

* isort: skip vitis

* update

* run pre-commit on all files

* graft contrib

* update

* dependabot

* ci

* Fix some tests related to Vitis changes

* Use accum_t for pool window in Vitis backend

* Add more tolerance to RNN tests

---------

Co-authored-by: Vladimir Loncar <[email protected]>
Co-authored-by: Javier Duarte <[email protected]>
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
* Cleanup Vivado .h files

* Cleanup Quartus .h files

* pre-commit for pytests

* precommit to hls4ml script

* Cleanup Vitis .h files

* precommit for other tests

* pycommit for pyproject.toml

* pre-commits for writer

* pre-commits for utils

* pre-commits for templates

* fix scrits, quartus_report

* pre-commit for model

* pre-commit for converters

* pre-commit for backens

* pre-commit for __init__.py

* pre-commit for contrib

* precommit for global files

* isort: skip vitis

* update

* run pre-commit on all files

* graft contrib

* update

* dependabot

* ci

* Fix some tests related to Vitis changes

* Use accum_t for pool window in Vitis backend

* Add more tolerance to RNN tests

---------

Co-authored-by: Vladimir Loncar <[email protected]>
Co-authored-by: Javier Duarte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants