-
Notifications
You must be signed in to change notification settings - Fork 464
Fix precommits #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix precommits #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a circular import (I think) in pytests. Will try to fix. |
jmduarte
approved these changes
Apr 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JanFSchulte
pushed a commit
to JanFSchulte/hls4ml
that referenced
this pull request
May 23, 2023
* Cleanup Vivado .h files * Cleanup Quartus .h files * pre-commit for pytests * precommit to hls4ml script * Cleanup Vitis .h files * precommit for other tests * pycommit for pyproject.toml * pre-commits for writer * pre-commits for utils * pre-commits for templates * fix scrits, quartus_report * pre-commit for model * pre-commit for converters * pre-commit for backens * pre-commit for __init__.py * pre-commit for contrib * precommit for global files * isort: skip vitis * update * run pre-commit on all files * graft contrib * update * dependabot * ci * Fix some tests related to Vitis changes * Use accum_t for pool window in Vitis backend * Add more tolerance to RNN tests --------- Co-authored-by: Vladimir Loncar <[email protected]> Co-authored-by: Javier Duarte <[email protected]>
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
* Cleanup Vivado .h files * Cleanup Quartus .h files * pre-commit for pytests * precommit to hls4ml script * Cleanup Vitis .h files * precommit for other tests * pycommit for pyproject.toml * pre-commits for writer * pre-commits for utils * pre-commits for templates * fix scrits, quartus_report * pre-commit for model * pre-commit for converters * pre-commit for backens * pre-commit for __init__.py * pre-commit for contrib * precommit for global files * isort: skip vitis * update * run pre-commit on all files * graft contrib * update * dependabot * ci * Fix some tests related to Vitis changes * Use accum_t for pool window in Vitis backend * Add more tolerance to RNN tests --------- Co-authored-by: Vladimir Loncar <[email protected]> Co-authored-by: Javier Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run the pre-commit hooks globally before the 0.7 release
Type of change
Tests
Standard tests should catch if this adds an error.
Checklist
pre-commit
on the files I edited or added.