-
Notifications
You must be signed in to change notification settings - Fork 462
Additional cleanup of the codebase #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this for 0.7.0 or 0.8.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and the qkeras tests pass: https://gitlab.cern.ch/fastmachinelearning/hls4ml/-/jobs/28750168
Is there anything else we should test specifically?
0.7.0. It doesn't make any changes to the functionality, it just reorganizes things a little bit. so it should be safe. If this messed up some imports, we would either get circular imports (all tests fail), or failure to import qkeras stuff (qkeras tests fail). But we can see from the logs that there are no import warnings and all tests pass. |
Additional cleanup of the codebase
Description
Minor cleanups around the codebase:
Layer
numbers_cpp()
fromLayer
toWriter
s so that no C++ code generation happens in IRQuantizer
s totypes.py
qkeras
imports (it is now a hard dependency so no need for checks if it is available)Type of change
Tests
No need for extra tests, no new features were introduced
Checklist
pre-commit
on the files I edited or added.