Skip to content

Fix RNN layers when strategy=resource #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2023

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented May 3, 2023

Description

The RNN layers erroneously transposed layers during initialization in the backend, despite this functionality being moved into a separate pass. I also cleaned up the code a bit to align it more with the rest of the codebase. It fixes #779.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

The existing test_rnn_accuracy has been extended to include strategy to verify the behavior is correct.

Test Configuration:

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar requested review from jmitrevs and elhamekhoda May 3, 2023 13:13
@vloncar vloncar added the please test Trigger testing by creating local PR branch label May 3, 2023
@vloncar vloncar mentioned this pull request May 8, 2023
8 tasks
@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels May 8, 2023
@jmitrevs jmitrevs merged commit a3cca72 into fastmachinelearning:main May 8, 2023
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSTM model with Strategy "resource" results in siginificant AUC loss
2 participants