Skip to content

Remove tf_to_hls #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented May 15, 2023

Description

This PR removes tf_to_hls. The tf_to_hls converter is outdated, unused, not exposed through the main API and based on old approach that likely won't work anymore. If we decide to support lower-level tensorflow API alongside Keras, this approach would be different anyway, so there's no reason to keep this around.

A question to be addressed: this converter introduced BiasAdd as a temporary layer and the associated optimizer. If ONNX and PyTorch converters don't plan to use it, it should be removed in this PR as well.

Type of change

  • Other (Specify) - Cleanup

Tests

Nothing to test.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label May 15, 2023
@jmitrevs
Copy link
Contributor

jmitrevs commented May 15, 2023

I think the pytest failure is transient. The test succeed on my computer.

@jmitrevs jmitrevs merged commit eca1ea3 into fastmachinelearning:main May 15, 2023
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants