Skip to content

Update dependencies, add testing extras #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

jmitrevs
Copy link
Contributor

Description

This updates the dependencies and adds a testing extras to simplify testing requirements.

I want to see if this passes the tests, but the requirements setup is still up for discussion.

Type of change

  • Other (Specify) - configuration and testing

Tests

should not affect the tests, which is the main thing I am testing with the PR.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Jul 18, 2023
Copy link
Contributor

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but some tests are failing - seems that there is a generic error of 'device out of space', so might just be a matter of re-running the pipeline.

@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Jul 19, 2023
@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Aug 2, 2023
@jmitrevs jmitrevs removed the please test Trigger testing by creating local PR branch label Aug 12, 2023
@jmitrevs jmitrevs added this to the v0.8.0 milestone Aug 12, 2023
Copy link
Contributor

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I think it can be rebased on top of main and merged.

@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Aug 16, 2023
@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Aug 27, 2023
@vloncar vloncar added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Sep 5, 2023
@vloncar
Copy link
Contributor

vloncar commented Sep 5, 2023

pre-commit.ci autofix

@vloncar vloncar added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Sep 5, 2023
@vloncar vloncar merged commit 26c4461 into fastmachinelearning:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants