Skip to content

Add option to configure IP version #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

AdrianAlan
Copy link
Contributor

@AdrianAlan AdrianAlan commented Aug 18, 2023

A small change of adding an option to specify the IP version, defaulting to 1.0.0.

Motivation: although it is a long time since the Y2K22 issue I hear people still run into it when running on systems where admins didn't install the patch. The same workaround was suggested in here. Issue mentioned in #633.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)

Tests

Please suggest tests for this change.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar
Copy link
Contributor

vloncar commented Aug 18, 2023

Nice!

But how would one set a version using the public API? The only way to use it is to create the config manually and call the keras_to_hls() or set it after the ModelGraph was created but before the write() is called.

@AdrianAlan
Copy link
Contributor Author

Now it should be possible to specify it through hls4ml.converters.create_config as well. Is there another way you thought about it?

PS Wouldn't you have the same concern about ClockUncertainty?

@vloncar
Copy link
Contributor

vloncar commented Aug 21, 2023

Looks good. It failed for the accelerator backend, so I added support for it as well.

@vloncar vloncar merged commit 3d227e5 into fastmachinelearning:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants