Skip to content

Let repack_stream optimizer inheirt original precision #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2023
Merged

Let repack_stream optimizer inheirt original precision #907

merged 2 commits into from
Nov 27, 2023

Conversation

calad0i
Copy link
Contributor

@calad0i calad0i commented Oct 31, 2023

A# Description

Currently repack_stream is not inheriting the precision defined for the reshape layer. This PR fixes that.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

test/pytest/test_repack_precision.py

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@calad0i calad0i mentioned this pull request Nov 7, 2023
Merged
7 tasks
@vloncar vloncar added this to the v0.8.1 milestone Nov 10, 2023
@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Nov 27, 2023
jmitrevs
jmitrevs reviewed Nov 27, 2023
View reviewed changes
@jmitrevs jmitrevs merged commit 033d438 into fastmachinelearning:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmitrevs jmitrevs jmitrevs approved these changes

Assignees
No one assigned
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@calad0i @jmitrevs @vloncar