feat: Implemented consistent error handling for rest registry apis #5554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ntkathole <[email protected]>
ntkathole
force-pushed
the
error_codes
branch
4 times, most recently
from
39bc8a8 to
e26b183
Compare
Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the consistent error responses with HTTP status codes included in the JSON response body for rest registry apis. Added global exception handlers for rest server.
Also, fixed the the entity to on-demand feature view relationship. The issue was that the lineage generation code was not creating relationships between entities and on-demand feature views.
Also, updated requirements to fix CI failure on torch install.