Remove duplicate _badge_json_generator function in views/badge.py#851
Closed
JeanomWilliams wants to merge 1 commit intofedora-infra:developfrom
Closed
Remove duplicate _badge_json_generator function in views/badge.py#851JeanomWilliams wants to merge 1 commit intofedora-infra:developfrom
JeanomWilliams wants to merge 1 commit intofedora-infra:developfrom
Conversation
Author
|
@gridhead, kindly review my PR request for my contribution. |
gridhead
requested changes
Mar 31, 2026
Member
gridhead
left a comment
gridhead
left a comment
There was a problem hiding this comment.
As this pull request targets the develop branch and not the swatantrya branch as clearly mentioned here, this pull request will not be accepted. Please create feature changes and/or bug fixes against the swatantrya branch for it to be considered for review.
Closing this pull request without merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate _badge_json_generator function in views/badge.py
I deleted the identical function in the private _badge_json_generator in the views/badge.py script.
It is identical and serves the same function as the public badge_json_generator in the tahrir/utils/badge.py. I also imported the badge_json_generator to the views/badge.py.
The call site was also corrected to reflect the import of the badge_json_generator function from utils/badge.py script.