Skip to content

Fix line too long in authorizations.py#862

Closed
Dev-JoyA wants to merge 1 commit intofedora-infra:swatantryafrom
Dev-JoyA:fix/admin-authorization-synthax-clean
Closed

Fix line too long in authorizations.py#862
Dev-JoyA wants to merge 1 commit intofedora-infra:swatantryafrom
Dev-JoyA:fix/admin-authorization-synthax-clean

Conversation

@Dev-JoyA
Copy link
Copy Markdown

@Dev-JoyA Dev-JoyA commented Mar 26, 2026

Closes #847

What changed

Fixed tox error in tahrir/endpoints/admin/authorizations.py:

Why

The initial code was causing tox not to run properly , due to line too error
Screenshot 2026-03-26 at 18 45 35

Validation

ran tox to ensure all test passed and there is no error

@Dev-JoyA Dev-JoyA changed the title Apply black formatting to authorizations.py Fix line too long in authorizations.py Mar 26, 2026
@gridhead gridhead self-requested a review March 31, 2026 04:43
@gridhead gridhead self-assigned this Mar 31, 2026
@gridhead gridhead added Bug स्वातंत्र्य Fedora Badges Revamp Project cle Community Linux Engineering labels Mar 31, 2026
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rework this pull request based on the suggested changes and review the AI-Assisted Contributions Policy to disclose the use of AI tools.

@Dev-JoyA
Copy link
Copy Markdown
Author

Implemented the requested review changes in tahrir/endpoints/admin/authorizations.py:

  • Moved badge_id and user extraction before first usage in both handlers.
  • Reused extracted variables in DB calls and response payloads.
  • Standardized naming to American English (authorized) for consistency.
    Issue reference: Closes Line too long in badge authorization response causes tox/flake8 failure #847
    Validation:
  • Ran local lint checks (ruff) on the updated file and confirmed no issues.
    AI disclosure:
    I used AI assistance (DeepSeek) to help draft commit/PR description text.
    I reviewed, edited, and validated the final code and wording before submitting.

@Dev-JoyA
Copy link
Copy Markdown
Author

@gridhead Kindly review my pr, I have resolved all issues .

@Dev-JoyA Dev-JoyA force-pushed the fix/admin-authorization-synthax-clean branch 3 times, most recently from c19ec10 to 815d53f Compare March 31, 2026 15:39
@Dev-JoyA Dev-JoyA requested a review from gridhead March 31, 2026 15:45
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that your commits are signed and the commit messages are no longer than 50 characters. Also, your disclosure of the use of the AI tooling has to be inside of the commit message.

Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into stepping up your work from here on out, rather than focusing on low-hanging fruit.

@Dev-JoyA Dev-JoyA force-pushed the fix/admin-authorization-synthax-clean branch from a6c7f8a to 2913a1f Compare April 1, 2026 11:41
@Dev-JoyA
Copy link
Copy Markdown
Author

Dev-JoyA commented Apr 1, 2026

Please look into stepping up your work from here on out, rather than focusing on low-hanging fruit.

Thanks for the feedback , understood.
I picked this initially because it blocked local tox/quality checks for contributors, but I understand your point about impact.
I’ll prioritize higher impact, iterative work going forward and focus on the main revamp problem statements.

@Dev-JoyA Dev-JoyA force-pushed the fix/admin-authorization-synthax-clean branch from 2913a1f to 7ba815e Compare April 1, 2026 12:09
@Dev-JoyA Dev-JoyA requested a review from gridhead April 1, 2026 12:12
@Dev-JoyA Dev-JoyA force-pushed the fix/admin-authorization-synthax-clean branch from 7ba815e to 9c677c8 Compare April 1, 2026 12:17
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commits and specify what AI tooling or model you have made use of within the commit messages!

Fixes the line-too-long authorization response issue and keeps handler variable naming consistent for clarity. This restores clean linting so tox/quality checks can run without failing on this file.

AI-Assisted: Used AI (DeepSeek) for drafting text; code changes reviewed and validated by me.
@Dev-JoyA Dev-JoyA force-pushed the fix/admin-authorization-synthax-clean branch from 9c677c8 to 54d7410 Compare April 2, 2026 09:28
@Dev-JoyA Dev-JoyA requested a review from gridhead April 2, 2026 09:29
Copy link
Copy Markdown
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since my repeated requests for signing the commits have gone unheeded, I am going ahead with rejecting this pull request. Please do better in your further attempts at contributing to this project's codebase.

@gridhead gridhead closed this Apr 3, 2026
@Dev-JoyA
Copy link
Copy Markdown
Author

Dev-JoyA commented Apr 4, 2026

Since my repeated requests for signing the commits have gone unheeded, I am going ahead with rejecting this pull request. Please do better in your further attempts at contributing to this project's codebase.

I am trying to record my contribution and I am just seeing this
the last commit have already been verified
I made sure to verify alll my commit after you mentioned it in another Pr
@gridhead

@Dev-JoyA
Copy link
Copy Markdown
Author

Dev-JoyA commented Apr 4, 2026

@gridhead I signed the commit and requested a re-review
Please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug cle Community Linux Engineering स्वातंत्र्य Fedora Badges Revamp Project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Line too long in badge authorization response causes tox/flake8 failure

2 participants