feat: Convert about page from Jinja2 template to React component#881
Merged
gridhead merged 2 commits intofedora-infra:swatantryafrom Mar 31, 2026
Merged
Conversation
gridhead
added
स्वातंत्र्य
gridhead
force-pushed
the
feat/about-page-react-component
branch
3 times, most recently
from
b25c0b4 to
03c237d
Compare
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
gridhead
force-pushed
the
feat/about-page-react-component
branch
from
03c237d to
232f827
Compare
gridhead
reviewed
Mar 31, 2026
Member
gridhead
left a comment
gridhead
left a comment
There was a problem hiding this comment.
One of the reasons why I retained this pull request and elected to add improvements atop it is because I see some genuine efforts being put in here. Your approach was quite off the mark, of course, because you were attempting to introduce server-side rendered Jinja templates into the ReactJS-based PWA client-side pages.
I want you to take a look at how I have done things and absorb as much learning as you can from it. Please note that this kind of spoonfeeding is an exception here and not the norm, and going forward, I will simply restrict myself to suggesting changes (if a pull request shows promise) or rejecting straightaway (if it is otherwise).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #880
Changes
/json/aboutAPI endpoint intahrir/views/explore.pyto expose the about page content as JSONretrieveAboutquery anduseRetrieveAboutQueryhook infrontend/src/features/call.jsfrontend/src/routes/about.jsxReact component matching the existing frontend architecture and theming/aboutroute infrontend/src/main.jsx