Skip to content

Conversation

@alestiago
Copy link
Contributor

@alestiago alestiago commented Nov 23, 2025

Status

READY

Breaking Changes

MAYBE YES

If the user was defining a Bloc.observer, now it will actually observe. Whereas before it would've been ignored.

Description

Before, only the localObserver will get notified of onError all other obvervables would be silenced.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago marked this pull request as ready for review November 23, 2025 20:51
@alestiago alestiago requested a review from felangel as a code owner November 23, 2025 20:51
@alestiago
Copy link
Contributor Author

@felangel friendly ping requesting for a review

@felangel
Copy link
Owner

@alestiago thanks for the PR and sorry for the delay! I took a look and I'm just wondering if you can provide some context for why this change is necessary. blocTest should only be used for unit testing a single bloc so it should ideally not involve any BlocObservers. Testing a BlocObserver should be done in a separate test and shouldn't require blocTest. Let me know what you think and thanks again!

@felangel felangel added enhancement New feature or request pkg:bloc_test This issue is related to the bloc_test package waiting for response Waiting for follow up labels Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pkg:bloc_test This issue is related to the bloc_test package waiting for response Waiting for follow up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants