Intellisense slow on 5k files

[TheColorRed]

I like the new auto completion tool and, I have a Laravel project that parses the files like so:

All 5568 PHP files parsed in 253 seconds. 178 MiB allocated.

When I type $someVar-> it takes about 2 seconds until the suggestions show up.

[felixfbecker]

Hmm, aggregating the completion results should be O(n).
This would be interesting to profile.

[TheColorRed]

Not sure if you saw this in the release notes of VSCode 1.9, but there is a php parser they are working on

https://github.com/Microsoft/tolerant-php-parser

Might be helpful in some way...

[felixfbecker]

Yes, I am aware of it 🙂

[autoferrit]

I have a similar issue on a Code igniter project. The autocompletion for class methods doesnt even pop up until I hit ctrl + space, then takes a few seconds. If i delete the -> and do it again, same thing. it doesnt cache the results either. but that is probably a different issue?

[jens1o]

@autoferrit afaik the results are not cached, but only the files where we get the results right. I think that's the bottleneck, yes.

[binarious]

CTRL + Space takes about 12 seconds for me. I do have 10k PHP files:

All 10140 PHP files parsed in 16 seconds. 504 MiB allocated.

macOS: 10.13
3,7 GHz Quad-Core
12 GB RAM
PHP: 7.1.10
Extension: 1.5.2
Code: 1.17.2

[bmax]

Hi! @felixfbecker willing to work on this -- Do you have any suggestions on the best place to start? Profiling it with XDebug?

[lndj]

Has anything help now?

[binarious]

I had to switch to PHP Intelephense.

[lndj]

@binarious is it faster?

[binarious]

@lndj It just works for me. Suggestions and method signatures show up instantly on very large projects.

[madbbb]

@TheColorRed
Have you disabled VSCode built-in suggestions? Try to set "php.suggest.basic" to false in settings.