Support PHP7.1 nullable types #292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 11, 2017
src/DefinitionResolver.php
Outdated
| if (is_string($node)) { | ||
| // Resolve a string like "bool" to a type object | ||
| return $this->typeResolver->resolve($node->returnType); | ||
| } |
There was a problem hiding this comment.
woops, this is meant to read resolve($node)
|
I applied this patch locally (with the string case fix) and it seemed to work. |
|
Cool, thanks for trying out! Tests are failing though, this seems to have caused some side-effect |
|
yeah, I cared more about getting rid of the problems window constantly popping up than I did about making sure it properly worked :( |
|
any news on this? It seems with latest master the tests shouldn't fail anymore. |
|
cursed... |
|
this can be closed now, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290