Skip to content

Update DefinitionResolver.php #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Sensirex
Copy link

from issue
#326

@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #333   +/-   ##
=========================================
  Coverage     84.15%   84.15%           
- Complexity      811      812    +1     
=========================================
  Files            59       59           
  Lines          1717     1717           
=========================================
  Hits           1445     1445           
  Misses          272      272
Impacted Files Coverage Δ Complexity Δ
src/DefinitionResolver.php 81.73% <0%> (ø) 276 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546660f...c79d3d2. Read the comment docs.

Copy link
Owner

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I already said before, this is not the fix. The bug is that type gets set to null, not that a null value isn't handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants