Allow getting type from define() node #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
============================================
+ Coverage 84.11% 84.33% +0.22%
- Complexity 826 834 +8
============================================
Files 59 59
Lines 1712 1724 +12
============================================
+ Hits 1440 1454 +14
+ Misses 272 270 -2
|
jens1o
previously approved these changes
Apr 23, 2017
|
Would it be possible to add a test that fails before the changes to prevent a regression? |
felixfbecker
previously approved these changes
Apr 23, 2017
|
Sure. Should I maybe add a folder for bugfixes? |
|
No, all tests are to prevent regressions. A test should not be coupled to a specific "bug", it should assert that the program behaves correctly. |
tests/DefinitionResolverTest.php
Outdated
|
|
||
| public function testGetDefinedFqn() | ||
| { | ||
| // define('XXX') (only one argument) must not introduce a new symbol |
There was a problem hiding this comment.
There should also be a test for the normal case
felixfbecker
approved these changes
Apr 24, 2017
lialan
pushed a commit
to lambdalab/php-language-server
that referenced
this pull request
Apr 30, 2017
* Allow getting type from define() node - fixes felixfbecker#364 * Add test case for DefinitionResolver
zfy0701
pushed a commit
to lambdalab/php-language-server
that referenced
this pull request
May 10, 2017
* Allow getting type from define() node - fixes felixfbecker#364 * Add test case for DefinitionResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #364
DefinitionResolver::getTypeFromNode()was missing a case fordefine()function call nodes.This caused the stubs file to contain lots of constants without an associated type.
Added the missing case and added checks to other parts concerning
define()nodes so that incomplete defines (only one argument) are not resolved as constants.