Fix error getting completions for 'new static' type #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=========================================
Coverage 84.24% 84.24%
- Complexity 699 700 +1
=========================================
Files 54 54
Lines 1568 1568
=========================================
Hits 1321 1321
Misses 247 247
|
| return new Types\Static_; | ||
| } | ||
| $className = (string)$class->getResolvedName(); | ||
|
|
||
| if ($className === 'self' || $className === 'parent') { |
There was a problem hiding this comment.
can these be checked through TokenKind too?
There was a problem hiding this comment.
There aren't TokenKinds for self and parent. I don't know why. They are parsed as QualifiedNames.
felixfbecker
approved these changes
Jun 13, 2017
lialan
pushed a commit
to lambdalab/php-language-server
that referenced
this pull request
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classTypeDesignatorcan now also be a StaticKeyword, after microsoft/tolerant-php-parser#149