Skip to content

Bump tolerant-php-parser #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2017
Merged

Conversation

roblourens
Copy link
Contributor

Shouldn't ^0.0.2 install 0.0.3?

Shouldn't ^0.0.2 install 0.0.3?
@ghost
Copy link

ghost commented Jun 17, 2017

@roblourens : not for 0.0.x versions, only 0.x.y

@felixfbecker
Copy link
Owner

@jrobeson are you sure? At least npm will install 0.0.3 for ^0.0.2 (but not 0.1.0)

@felixfbecker
Copy link
Owner

build is failing, there seems to be an incorrect assertion

@ghost
Copy link

ghost commented Jun 17, 2017

pretty sure.

@felixfbecker
Copy link
Owner

confirmed

@ghost
Copy link

ghost commented Jun 17, 2017

My assertion is not quite right!

The ^ operator behaves very similarly but it sticks closer to semantic versioning, and will always allow non-breaking updates. For example ^1.2.3 is equivalent to >=1.2.3 <2.0.0 as none of the releases until 2.0 should break backwards compatibility. For pre-1.0 versions it also acts with safety in mind and treats ^0.3 as >=0.3.0 <0.4.0.

@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #415 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #415      +/-   ##
============================================
+ Coverage     84.45%   84.51%   +0.06%     
  Complexity      654      654              
============================================
  Files            54       54              
  Lines          1563     1563              
============================================
+ Hits           1320     1321       +1     
+ Misses          243      242       -1
Impacted Files Coverage Δ Complexity Δ
src/DefinitionResolver.php 85.16% <0%> (+0.22%) 229% <0%> (ø) ⬇️

@felixfbecker felixfbecker merged commit f971057 into felixfbecker:master Jun 17, 2017
lialan pushed a commit to lambdalab/php-language-server that referenced this pull request Oct 7, 2017
* Bump tolerant-php-parser

* Update test for new parser static support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants