-
Notifications
You must be signed in to change notification settings - Fork 92
Change readme for 'Format code' (new extension PHP CS Fixer) with demo png and gif #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… and 'Format code' with PHP CS Fixer extension. Added demo png for former and demo gif for latter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to not include gifs for other extensions in the readme. A link should be fine.
Understandable. Changed to remove GIF for 3rd party extension, just link now. |
README.md
Outdated
Please use a dedicated extension like [PHP CodeSniffer](https://marketplace.visualstudio.com/items?itemName=ikappas.phpcs). | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this too
Changes made. |
🎉 This PR is included in version 2.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Since "phpcs" does not provide the Format Document feature, recommending "PHP CS Fixer" for this and keeping phpcs recommendation for linting warnings. Added demo png for phpcs and demo gif for PHP CS Fixer.
See issue #172