Skip to content

Conversation

@chinglee-iot
Copy link

Implement get core ID with interrupt disabled

Description

  • Update RP2040 to use the new port macro.
  • Use parentheses on macro arguments.
  • Update vTaskYieldWithinAPI to acquire the core ID with interrupt disabled.
  • Use const variable in vTaskEnterCriticalFromISR since core ID won't change in ISR.

Test Steps

Build and run RP2040 main_full_smp without problem.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

FreeRTOS#1204

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Owner

@felixvanoost felixvanoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@felixvanoost felixvanoost merged commit 37c71b9 into felixvanoost:pass-core-id-to-critical-nesting-count-macros Dec 14, 2024
@chinglee-iot chinglee-iot deleted the update-core-id-fix branch August 7, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants