Skip to content

MOVE-4732 Bugfix in creation of database#1346

Draft
larsbard wants to merge 1 commit into
mainfrom
bugfix-MOVE-4732-add-longblob
Draft

MOVE-4732 Bugfix in creation of database#1346
larsbard wants to merge 1 commit into
mainfrom
bugfix-MOVE-4732-add-longblob

Conversation

@larsbard

Copy link
Copy Markdown
Contributor

…column

@larsbard larsbard requested a review from teedjay December 17, 2025 12:24

@teedjay teedjay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@larsbard larsbard changed the title MOVE-4732 Bugfix in creation of database, added longblob for content … MOVE-4732 Bugfix in creation of database Dec 17, 2025
@larsbard larsbard marked this pull request as draft December 17, 2025 12:36
@larsbard

larsbard commented Dec 19, 2025

Copy link
Copy Markdown
Contributor Author

Slettet opprinnelig database, laget ny database og testet på nytt med mysql:

mysql> SHOW CREATE TABLE next_move_message_entry;
+-------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table |
+-------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| next_move_message_entry | CREATE TABLE next_move_message_entry (
entry_id int NOT NULL,
content longblob,
filename varchar(255) DEFAULT NULL,
message_id varchar(255) DEFAULT NULL,
size bigint DEFAULT NULL,
PRIMARY KEY (entry_id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci |
+-------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.002 sec)

Ser altså ut som at det blir laget som default longblob i mysql 9.5 og i mysql 8.4.7.

Får samme resultat i MariaDB 11.8

Jeg er derfor usikker på om denne PRen er nødvendig, eller bør vi eksplisitt sette columnDefinition = "LONGBLOB" på content-atributten i NextMoveMessageEntry.java (eneste endringen i denne PRen)?

@larsbard larsbard requested a review from teedjay December 19, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants