Update Go Components page - to align with 2.1.0 #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tpmccallum [email protected] Signed-off-by: Timothy McCallum <[email protected]>
|
🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1128-vf9sqdzp.fermyon.app |
itowlson
reviewed
Jan 8, 2024
content/spin/v2/go-components.md
Outdated
| @@ -157,12 +184,9 @@ now receive requests in route `/hello`: | |||
| <!-- @selectiveCpy --> | |||
|
|
|||
| ```bash | |||
| $ curl -i localhost:3000/hello | |||
| $ curl -i localhost:3000 | |||
There was a problem hiding this comment.
This no longer matches the manifest (I don't know whether you want to change the route in the manifest or restore it here, but if the former then line 182 will also need a change).
There was a problem hiding this comment.
Great catch, thank you.
I have updated the curl command to make the request to the correct endpoint.
Signed-off-by: tpmccallum [email protected] Signed-off-by: Timothy McCallum <[email protected]>
itowlson
approved these changes
Jan 8, 2024
Signed-off-by: tpmccallum [email protected] Co-authored-by: itowlson <[email protected]> Signed-off-by: Timothy McCallum <[email protected]>
Signed-off-by: tpmccallum [email protected] Co-authored-by: itowlson <[email protected]> Signed-off-by: Timothy McCallum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tpmccallum [email protected]
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title,template, anddate` are all settemplates/*.hbsfiles) that points to a document.mdthat is set to publish in the future? If so please only publish the.mdand.hbschanges in real-time (otherwise there will be a menu item pointing to a.mdfile that does not exist)cat -ve <filename> | grep '^M' | wc -land expect 0 as a result)bart checkPREVIEW_MODE=1and runnpm run stylesto update styling)npm run testand resolved all errors