fix(seed): repair broken ts-seed and csharp-seed Dockerfile builds#15730
fix(seed): repair broken ts-seed and csharp-seed Dockerfile builds#15730davidkonigsberg wants to merge 1 commit into
Conversation
Co-Authored-By: David Konigsberg <davidakonigsberg@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
SDK Generation Benchmark ResultsComparing PR branch against median of 5 nightly run(s) on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
|
Closing as superseded — both Dockerfiles were already remediated on
Nothing left to do here. Closing. |
Description
Linear ticket: N/A
docker/seed/Dockerfile.tsanddocker/seed/Dockerfile.csharphave been failing onmainsince:RUN corepack prepare pnpm@10.20.0withInternal Error: Cannot find matching keyid(nodejs/corepack#612). The version of corepack bundled withnode:22.12-slimships with outdated signing keys and rejects newer pnpm/yarn releases.chore(csharp): upgrade WireMock.Net from 1.25.0 to 2.2.0) —dotnet restore /dependencies.csprojfails with NU1605 package downgrade errors:WireMock.Net 2.2.0 → WireMock.Net.Minimal 2.2.0 → Scriban.Signed 7.0.6 → System.Text.Json (>= 10.0.5)conflicts with the pinned8.0.5.Grpc.Net.ClientFactory 2.63.0 → Microsoft.Extensions.Http 6.0.0 → Microsoft.Extensions.Logging 10.0.0 → Microsoft.Extensions.Logging.Abstractions (>= 10.0.0)conflicts with the pinned8.0.2.These two images are referenced from the new grype scan matrix in #15729, where the failures were surfaced again.
Changes Made
docker/seed/Dockerfile.ts: prependRUN npm install -g corepack@latestso corepack has up-to-date signing keys beforecorepack prepareruns. Added a comment explaining why.docker/seed/Dockerfile.csharp: bump warmup-cachedependencies.csprojversions to satisfy transitive constraints fromWireMock.Net 2.2.0andGrpc.Net.ClientFactory 2.63.0:System.Text.Json:8.0.5→10.0.5Microsoft.Extensions.Logging.Abstractions:8.0.2→10.0.0Testing
docker/seed/Dockerfile.tslocally — passes (Successfully tagged fern-ts-seed-test:local).docker/seed/Dockerfile.csharplocally — passes;dotnet restore /dependencies.csprojreportsRestored /dependencies.csproj (in 7.18 sec).with no NU1605 errors (only a few benign NU1701 netstandard2.0 compatibility warnings, unchanged from before).Build seed containersworkflow on this PR.Link to Devin session: https://app.devin.ai/sessions/4363b615bc51422483ddb7d519a4ee12
Requested by: @davidkonigsberg