fix(cli): error when --instance does not match any configured docs instance#16721
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
fix(cli): error when --instance does not match any configured docs instance#16721devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…stance Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Tests now mock dependencies (TaskContext, publishDocs, core-utils) and call the real runRemoteGenerationForDocsWorkspace() function, verifying behavior through the mocked dependencies rather than duplicating logic. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
fern generate --docs --instance <url>with a URL that doesn't exactly match any configured instance indocs.yml, the CLI silently falls back to publishing toinstances[0]instead of erroring.This caused docs to be published to the wrong production site — the user specified a Glean instance URL but docs were published to the first instance (
partner-docs-ddn).Changes Made
In
runRemoteGenerationForDocsWorkspace.ts:When
instanceUrlis provided:find()— no fallback toinstances[0]failAndThrowwith a message listing available instancesWhen
instanceUrlisundefined(no--instanceflag):instances[0]The CLI-v2
PublishCommand.resolveInstanceUrlalready handles this correctly by throwingCliErroron mismatch; this fix aligns the v1 code path.Testing
pnpm run checkpassesLink to Devin session: https://app.devin.ai/sessions/4d76819a21d049f7a33174acd031e595