Disable Launchy using ENV variable instead of completely redefining deliver! method.
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deliver!` method.
|
@pseudomuto are you going to merge this PR soon? I think plenty of developers who use latests versions of |
Contributor
|
My apologies. I wasn't pinged here so I didn't see it. 👀 |
pseudomuto
approved these changes
Jan 14, 2018
Contributor
pseudomuto
left a comment
pseudomuto
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the fix man!
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a new version of
letter_openeris released and there's a change inLetterOpener::Message.rendered_messagesmethod (now we send location usingoptionsparam)letter_opener_webis broken whenletter_opener_webas delivery method is used (sorry about that).There's a bug report about it here ryanb/letter_opener#147. I think it makes sense to disable Launchy using
LAUNCHY_DRY_RUNenv variable (https://github.com/copiousfreetime/launchy/blob/master/lib/launchy.rb#L15) to avoid future issues with compatibilities withletter_openergem. What do you think?