Fix: Select with searchable and preloaded option empty state #18529 #18641
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of isPreloaded to decide whether the showNoResultsMessage should be rendered immediately when the dropdown is opened.
danharrin
requested changes
Dec 24, 2025
Member
danharrin
left a comment
danharrin
left a comment
There was a problem hiding this comment.
I think we need a dedicated method for this situation as the current message doesn't make sense when there is no active search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem is well described here: #18529
Visual changes
Functional changes
Improves the UX of searchable selects by immediately displaying a “no results” message when the component has zero options and is preloaded.
Currently, the user must type something before any feedback appears. This update ensures the empty-state message is shown right away, providing clearer guidance.
If this approach is preferred, I can also implement a dedicated message specifically for this scenario.
composer cscommand.