Skip to content

Conversation

@robinvda
Copy link

@robinvda robinvda commented Dec 16, 2025

Description

Fixes #18467

Fixes a undefined column error from Postgres when using table search. Also fixes a bug where table search would always force the search term to be lowercase by adding forceSearchCaseInsensitive() to Table (same implementation as in Column).

Visual changes

None

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Dec 16, 2025
@danharrin danharrin added bug Something isn't working pending review labels Dec 17, 2025
@danharrin danharrin added this to the v4 milestone Dec 17, 2025
@danharrin
Copy link
Member

Can you explain more about the case insensitivity fix, I don't really understand it

@robinvda
Copy link
Author

Using Postgres, the search term was always forced to lowercase (using Str::lower()). So even if i search for John, it would only find results with john, not John. I'm on holiday for 2 weeks now so if necessary i can further check this when i get back.

@danharrin
Copy link
Member

In the query, is lower(column) or just column generated? It should be the first for Postgres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Postgres throws "undefined column" when using searchable in tables

3 participants