fix: Apply StateCasts to child components in Repeater for JSON columns #18727
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Repeater's afterStateHydrated restructures items with UUID keys, it calls rawState() which triggers clearCachedDefaultChildSchemas(). Subsequent calls to getItems() create new child schemas that haven't been through hydrateState(), so StateCasts (like FileUploadStateCast) are never applied. This fix applies StateCasts to child components after creating schemas in getItems() for non-relationship repeaters. This ensures FileUpload and other StateCast-dependent components have properly normalized state. Fixes filamentphp#18726
Member
|
Can you please submit a reproduction repository for this issue @iotron so I can investigate myself and also test that your fix works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18726
When
Repeater'safterStateHydratedrestructures items with UUID keys, it callsrawState()which triggersclearCachedDefaultChildSchemas(). Subsequent calls togetItems()create new child schemas that haven't been throughhydrateState(), soStateCasts(likeFileUploadStateCast) are never applied.This causes FileUpload components inside non-relationship Repeaters (JSON columns) to fail with:
The error occurs because
FileUpload::getUploadedFiles()expects UUID-keyed arrays but receives raw strings.Solution
Apply
StateCaststo child components after creating schemas ingetItems()for non-relationship repeaters. The existingcastStateAfterLoadingFromRelationships()method handles this perfectly - it recursively processes child schemas and is idempotent.For relationship-based repeaters, this is already handled via
loadStateFromRelationships(shouldHydrate: true).Test Plan