Database Notification Action Icon #18751
Open
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a database notification with an action with an icon is sent, the enum will be serialized to just the value without "heroicon-" prefix to db. This will add the prefix and icons are showing up. Signed-off-by: ed <[email protected]>
danharrin
requested changes
Dec 24, 2025
Member
danharrin
left a comment
danharrin
left a comment
There was a problem hiding this comment.
Instead of checking if the icon is a Heroicon, check if it has the ScalableIcon interface and call getIconForSize() to get the full icon string.
Also, do we need to do the same for the main notification icon in toArray()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a database notification with an action with an icon is sent, the enum will be serialized to just the value without "heroicon-" prefix to db.
This will add the prefix and icons are showing up.
Visual changes
icon will show up
Functional changes
none