Feature: Show modal when extracting password protected archives

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: Show modal when extracting password protected archives #9948

Change List

• User is prompted for password when extracting an encrypted archive
• I created a method that tells if an archive is encrypted
• I moved the creation of destinatioFolder to prevent the folder from being created even when the user presses Cancel
• I added translations for the Extract button

Others

• There is a bug with 7z archives, but it also exists in the release version (I'm opening a different issue to track that)

Comments
Note that with the SevenZip library we can pass the password only in the constructor

Validation
How did you test these changes?

• Built and ran the app

[yaira2]

Do you think we can reuse the existing "extract to" dialog and add the logic for this?

[ferrariofilippo]

Do you think we can reuse the existing "extract to" dialog and add the logic for this?

I think I can add the password field to the dialog and make it visible only when the archive is encrypted. Is that ok?

[yaira2]

I think that's acceptable, we'll probably add additional options in the future so having it one dialog will be helpful.

[ferrariofilippo]

Now when the archive is encrypted it looks like this
Edit. I'm not sure if we should leave Insert archive password

[yaira2]

I'd expect the other options to only show if you click "Extract To"

[ferrariofilippo]

I'd expect the other options to only show if you click "Extract To"

It already works like that

[yaira2]

I think we'll need to make a couple of changes to the dialog to make it more generic

1. Change the title to "Extract Archive"
2. Move the check box to the last row

[yaira2]

Looks good UI wise.

[yaira2]

LGTM