Skip to content

Fix: Fixed crash that would occur when using the new tab keyboard shortcut #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

QuaintMako
Copy link
Contributor

@QuaintMako QuaintMako commented Dec 13, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

What has been done

  • Forcing to wait the end of the tab opening processure.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 changed the title Fix: App no longer crash when holding "open new tab" accelerator down Fix: Fixed crash that would occur when using the new tab keyboard shortcut Dec 13, 2022
@yaira2
Copy link
Member

yaira2 commented Dec 13, 2022

I can still reproduce the issue

@QuaintMako
Copy link
Contributor Author

Back to the drawing board then.

@QuaintMako QuaintMako closed this Dec 13, 2022
@yaira2
Copy link
Member

yaira2 commented Dec 13, 2022

It's only when I hold down on ctrl + t.

@QuaintMako QuaintMako deleted the 2145_RetakeTabCrash branch January 3, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: App crashes when opening a lot of tabs
2 participants