Skip to content

Code Quality: Introduced AppThemeModeService #14574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jan 29, 2024

Summary

  • Removed ThemeHelper
  • Added AppThemeModeService

Steps To Validate

  1. Launch the app
  2. Go to settings
  3. Switch theme mode
  4. Exit and re-launch
  5. See no expected behavior

PR Checklist

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa 0x5bfa closed this Jan 29, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Introduce-AppThemeModeService branch February 13, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant