-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Code Quality: Removed NetworkDrivesViewModel and NetworkDrivesAPI #15155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaira2
merged 12 commits into
files-community:main
from
0x5bfa:5bfa/CQ-INetworkDrivesService
Apr 16, 2024
Merged
Code Quality: Removed NetworkDrivesViewModel and NetworkDrivesAPI #15155
yaira2
merged 12 commits into
files-community:main
from
0x5bfa:5bfa/CQ-INetworkDrivesService
Apr 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
previously approved these changes
Apr 11, 2024
hishitetsu
reviewed
Apr 15, 2024
Co-authored-by: hishitetsu <[email protected]>
Co-authored-by: hishitetsu <[email protected]>
Co-authored-by: hishitetsu <[email protected]>
hishitetsu
reviewed
Apr 15, 2024
hishitetsu
reviewed
Apr 15, 2024
Aside from the review comments, there doesn't seem to be any regression from this change. |
Co-authored-by: hishitetsu <[email protected]>
hishitetsu
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that evry code related network share point is in the service class
PR Checklist
Related Code Quality: Reduce duplicated functionality classes #14572
None
Screenshots
None