Skip to content

Code Quality: Removed NetworkDrivesViewModel and NetworkDrivesAPI #15155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 16, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 11, 2024

Summary

Now that evry code related network share point is in the service class

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Code Quality: Reduce duplicated functionality classes #14572
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

yaira2
yaira2 previously approved these changes Apr 11, 2024
@yaira2 yaira2 added needs - code review ready to merge Pull requests that are approved and ready to merge needs - testing Pull request requires testing before being merged and removed needs - code review labels Apr 11, 2024
0x5bfa and others added 3 commits April 15, 2024 09:42
@hishitetsu
Copy link
Member

hishitetsu commented Apr 15, 2024

Aside from the review comments, there doesn't seem to be any regression from this change.

@yaira2 yaira2 requested a review from hishitetsu April 16, 2024 22:35
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 2241346 into files-community:main Apr 16, 2024
6 checks passed
@yaira2 yaira2 removed the needs - testing Pull request requires testing before being merged label Apr 16, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-INetworkDrivesService branch April 16, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants