Skip to content

Code Quality: Replpace LibraryManager with IWindowsLibraryService #15219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 18, 2024

Summary

Introduced an interface for windows library to cover up its implementation.

  • Moved dialog displayers into SidebarViewModel
  • Replace App.WindowsLibraryService property references with DI
  • Refactor

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related: Code Quality: Reduce duplicated functionality classes #14572
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

@0x5bfa 0x5bfa closed this Apr 21, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-IWindowsLibraryService branch April 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant