Skip to content

Code Quality: Reorganize App.Services namespace #15473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 26, 2024

Summary

  • Unified namespace ‘Storables’
  • Created App, Storage and Windows folders.
  • Removed IFileExplorerService (unused)
  • Removed IVolumeInfoFactory (unused)

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app

yaira2
yaira2 previously approved these changes May 26, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 28, 2024
@yaira2 yaira2 merged commit de9c374 into files-community:main May 28, 2024
6 checks passed
0x5bfa added a commit to 0x5bfa/Files that referenced this pull request May 31, 2024
0x5bfa added a commit to 0x5bfa/Files that referenced this pull request May 31, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-ServicesNamespace branch June 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants