Skip to content

Code Quality: Fixed an issue where folder selection dialog wouldn't work #15553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Right-click an archive.
  2. Select Extract -> Extract files.
  3. Click the Browse button and select a destination folder.
  4. It no longer crashes and can be extracted normally.

@hishitetsu hishitetsu changed the title Fixed issue where folder selection wouldn't work Fix: Fixed an issue where folder selection dialog wouldn't work Jun 5, 2024
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. I didn’t check code after user select files, my bad…
Code wise, looks pretty good.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed an issue where folder selection dialog wouldn't work Code Quality: Fixed an issue where folder selection dialog wouldn't work Jun 5, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 5, 2024
@yaira2 yaira2 merged commit 9f6f55f into files-community:main Jun 5, 2024
6 checks passed
@hishitetsu hishitetsu deleted the FixSelectFolder branch June 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Crash when extracting a folder to a OneDrive folder (Business or personal)
3 participants