Skip to content

Code Quality: Simplify UI operation layer for Copy and Cut #15724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jun 28, 2024

Summary

This is a part of Storage Abstraction.
The short-term goals are:

  • Remove UIFilesystemHelpers (doing this)
  • Refactor ShellViewModel
  • Create StorageQueryService
  • Create StorageEnumerationService
  • Create StorageOperationService

Resolved / Related Issues

  • https://github.com/files-community/Files/issues/8974

Steps used to test these changes

  1. Open Files app
  2. Do cut, copy

@yaira2
Copy link
Member

yaira2 commented Jun 30, 2024

This looks good to me on the surface, but further review is required before merging.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 4, 2024
@yaira2 yaira2 merged commit aa05b1a into files-community:main Jul 4, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-StorageAbstractionUILayer branch July 4, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants