Skip to content

Fix: Fixed an issue where the title bar drag region was sometimes missing #16549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 9, 2024

Conversation

XTorLukas
Copy link
Contributor

@XTorLukas XTorLukas commented Nov 29, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open enough tabs that the scroll buttons are displayed
  2. Fully close Files (enable continue where you left off)
  3. Reopen Files
  4. Tabs don't overflow and the gap is maintained.

image

  • Gap is identical at different dpi's e.g. 1.25

@XTorLukas XTorLukas marked this pull request as ready for review November 29, 2024 20:06
@XTorLukas XTorLukas requested a review from 0x5bfa December 1, 2024 10:51
@yaira2 yaira2 changed the title Fix: Fixes the problem where tabs overflow and the gap is not preserved. Fix: Fixed an issue where the title bar drag region was sometimes missing Dec 2, 2024
@XTorLukas XTorLukas requested a review from yaira2 December 8, 2024 12:34
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 9, 2024
@yaira2 yaira2 merged commit 45aa133 into files-community:main Dec 9, 2024
5 checks passed
Lamparter pushed a commit to Lamparter/Files that referenced this pull request Dec 10, 2024
@XTorLukas
Copy link
Contributor Author

Solved problems in this revert PR #16595

@XTorLukas XTorLukas deleted the xtorlukas/Fix-DragBarRegion branch December 10, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
3 participants